Implement multipolygon support for table buildings #2476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement multipolygon support for table
buildings
and convert the analysers accordingly.Notes:
b1.id > b2.id
in analyser_osmosis_building_overlaps I assume this was just such that comparing [A B C] with [A B C] would go like [BA, CA, CB] (n!-n comparisons) rather than [BA, CA, AB, CB, AC, BC] (n^2-n comparisons, if b1!=b2), e.g. it doesn't have to know the numerical value. This makes it much easier to keep it as it is as it may have to compare relations with ways.buildings.relation
property. Based on the commit history this was added a decade ago in case a way with tagbuilding=*
was part of a multipolygon relation. However, nowadays thebuilding=*
tag should be on the multipolygon relation itself, not on the (outer) way. If it's on the inner way, that's a valid building. (Additionally, this inadvertently also blocked detections involving buildings in e.g. associatedStreet relations)