Fixed analysis warning about if statements in PlateHorizontalGraph. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
oskopek
approved these changes
Dec 22, 2016
| } | ||
|
|
||
| public Vector<Peak> findPeak_derivative(int count) { |
There was a problem hiding this comment.
Optional: Would you formatting the name of this and the other findPeak method to camelCase?
| int a, b; | ||
| public Vector<Peak> findPeak_derivative() { | ||
| int a = 2; | ||
| int b = this.yValues.size() - 1 - 2; | ||
| float maxVal = this.getMaxValue(); |
There was a problem hiding this comment.
Optional: Remove all the extra this statements if you feel like it :) See #42
…hanged empty if statements to while statements. Removed unused argument count. Removed unused field handle. Changed Plate.java to reflect this change.
… unnecessary this. statements.
FridaTveit
force-pushed
the
FixCodeAnalysisWarningsInPlateHorizontalGraph
branch
from
437f960 to
c92fc62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed empty if statements to while statements. Removed unused argument 'count'. Removed unused field 'handle'. Changed Plate.java to reflect this change. This relates to issue #18 .