Skip to content

Conversation

khorevaa
Copy link
Member

@khorevaa khorevaa commented Nov 8, 2017

@artbear - Надо поскорее влить.

Copy link
Member

@artbear artbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Нужны небольшие исправления.

2 Почему так много коммитов??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если мы все равно ищем в массив, и добавляем, если не найдено, то проще вместо массива юзать Соответствие

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделал

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Неверно менять версию в девелоп-ветке :(
Менять нужно при выпуске релиза
Откатывай строку

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это не мои строчки... Это то что отсутвует в develop - прямые изменения в master

@artbear artbear self-assigned this Nov 8, 2017
@artbear artbear added this to the 2.3.0 milestone Nov 8, 2017
@artbear artbear merged commit 694907f into oscript-library:develop Nov 8, 2017
@khorevaa khorevaa deleted the fix-err branch November 9, 2017 12:33
@artbear artbear modified the milestones: 2.3.0, 2.4.0 Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants