feat: Reader support open db from embed.fs #173
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschwald
reviewed
Apr 29, 2025
There was a problem hiding this comment.
I don't really see the point of adding a helper function for this. You end up saving a single ReadFile line plus whatever error handling your application needs. This change also hides that fact that you are just reading the bytes into memory and then opening that.
|
|
||
| reader, err := FromBytes(data) | ||
| if err != nil { | ||
| _ = munmap(data) |
There was a problem hiding this comment.
There is no memory map. It doesn't make sense to cal this.
| return nil, err | ||
| } | ||
|
|
||
| reader.hasMappedFile = true |
There was a problem hiding this comment.
You are loading the file into memory, not memory mapping it.
| } | ||
|
|
||
| reader.hasMappedFile = true | ||
| runtime.SetFinalizer(reader, (*Reader).Close) |
There was a problem hiding this comment.
There is no point is setting a finalizer here.
| @@ -48,6 +49,23 @@ type Metadata struct { | |||
| RecordSize uint `maxminddb:"record_size"` | |||
| } | |||
|
|
|||
| func OpenWithEmbedFS(f embed.FS, path string) (*Reader, error) { | |||
There was a problem hiding this comment.
This would need documentation and the name is somewhat awkward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reader support open db from embed.fs