Skip to content

Remove mpoly constructors for action polynomials #5494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgoettgens merged 1 commit into from
Oct 24, 2025
Merged

Remove mpoly constructors for action polynomials #5494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions experimental/ActionPolyRing/src/Types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,6 @@ mutable struct DifferencePolyRingElem{T} <: ActionPolyRingElem{T}
new{T}(upre, dpr, false, zeros(Int, length(upre)))
end

function DifferencePolyRingElem{T}(dpr::DifferencePolyRing{T}, mpre::MPolyRingElem{T}) where {T}
upr = dpr.upoly_ring
@req upr.mpoly_ring === parent(mpre) "The parent does not match"
new{T}(upr(collect(coefficients(mpre)), collect(exponents(mpre))), dpr, false, zeros(Int, length(mpre)))
end

end

### Differential ###
Expand Down Expand Up @@ -159,12 +153,6 @@ mutable struct DifferentialPolyRingElem{T} <: ActionPolyRingElem{T}
new{T}(upre, dpr, false, zeros(Int, length(upre)))
end

function DifferentialPolyRingElem{T}(dpr::DifferentialPolyRing{T}, mpre::MPolyRingElem{T}) where {T}
upr = dpr.upoly_ring
@req upr.mpoly_ring === parent(mpre) "The parent does not match"
new{T}(upr(collect(coefficients(mpre)), collect(exponents(mpre))), dpr, false, zeros(Int, length(mpre)))
end

end

###############################################################################
Expand Down
4 changes: 0 additions & 4 deletions experimental/ActionPolyRing/test/ActionPolyRing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,14 +646,10 @@ using Test
g = (u1_010 - 2) * (u1 - u1_100 + 3)
@test dpr(data(f)) == f
@test dpr(data(f)) !== f
@test dpr(data(data(f))) == f
@test dpr(data(data(f))) !== f
@test dpr(f) === f

@test dpr(data(g)) == g
@test dpr(data(g)) !== g
@test dpr(data(data(g))) == g
@test dpr(data(data(g))) !== g
@test dpr(g) === g

@test f == 2*u2_100*u1_100 - u3_111*u1_100 - 2*u2_100*u1 + u3_111*u1 - 6*u2_100 + 3*u3_111
Expand Down
Loading