Use base_ring in action poly ring
#5488
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Nemocas/AbstractAlgebra.jl#2182 @fingolfin suggested to change the name of the field name
mpoly_ringfor universal polynomial rings. This causes a test failure in the action polynomial code. Previously the code directly accessed the fieldmpoly_ringwhich was a bad idea in the first place. I've now adapted it to call the newbase_ringmethod for universal polynomial rings instead. Of course this will break the tests here again since Nemocas/AbstractAlgebra.jl#2182 isn't merged yet. Instead ofbase_ring(upr)we could write something likeparent(data(upr()))which would serve the same purpose but be compatible with the current AbstractAlgebra release.@SirToby25 Do you actually need these constructors which currently access the
mpoly_ringfield directly? Note that the current implementations is also rather inefficient.