Avoid base_ring for universal polynomial rings in ActionPolyRing
#5427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my mission to completing Nemocas/AbstractAlgebra.jl#2182 I discovered that the experimental
ActionPolyRinguses the universal polynomial rings. With this AbstractAlgebra PR the meaning ofbase_ringfor universal polynomial rings will change andcoefficient_ringshould be used instead. Perhapscoefficient_ringshould be implemented for theActionPolyRingas well? (See: #1505 and Nemocas/AbstractAlgebra.jl#1207)@SirToby25 I'm pinging you as you are mentioned in the docs of the
ActionPolyRing.