Replace remaining base_ring calls for universal polynomials
#5423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ping @antonydellavecchia. |
lgoettgens
added
the
release notes: not needed
antonydellavecchia
approved these changes
Oct 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5423 +/- ##
==========================================
- Coverage 83.99% 83.99% -0.01%
==========================================
Files 721 721
Lines 98479 98479
==========================================
- Hits 82718 82717 -1
- Misses 15761 15762 +1
🚀 New features to boost your workflow:
|
antonydellavecchia
merged commit b2f5345
into
oscar-system:master
37 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5420 I missed some calls to
base_ring. Now the "Serialization/upgrades" tests, which are still failing in Nemocas/AbstractAlgebra.jl#2182, run fine on my machine with the respective AbstractAblgebra version for the PR.