adjust version of dependency JSON - #11
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 70.46% 68.61% -1.85%
==========================================
Files 4 4
Lines 325 325
==========================================
- Hits 229 223 -6
- Misses 96 102 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- JSON is now at version 1.6, we had required 0.21, which is too small for Oscar.jl - call `Oscar.GAP.GapObj` instead of `Oscar.GAP.julia_to_gap` (since GAP.jl 0.12.0, released end of 2024) - call `Oscar.polynomial_ring`, `Oscar.ZZRingElem` instead of `Oscar.PolynomialRing`, `Oscar.fmpz` - increase the version number from 0.1.2 to 0.1.3
In fact Chevie.jl needs Julia 1.11, since the two argument version of `allequal` is used. (Alternatively, Compat.jl could be loaded. That is whay the error does not show up when Oscar.jl is loaded. Note that we run the tests with Chevie.jl but without Oscar.jl.)
in order to get rid of the warnings
ThomasBreuer
commented
Jun 3, 2026
ThomasBreuer
left a comment
ThomasBreuer
left a comment
Member
Author
There was a problem hiding this comment.
@JuliaRegistrator register
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pkg.add("Chevie")andPkg.add("Oscar")results in a very old version of Oscar.jl that is content with JSON 0.21.)Oscar.GAP.GapObjinstead ofOscar.GAP.julia_to_gap(since GAP.jl 0.12.0, released end of 2024).Oscar.polynomial_ring,Oscar.ZZRingEleminstead ofOscar.PolynomialRing,Oscar.fmpz.resolves #10