Skip to content

align reasoning model params with OpenAI spec & add 'minimal' effort support #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaajeevChandran wants to merge 1 commit into
base: main
Choose a base branch
from
Open

align reasoning model params with OpenAI spec & add 'minimal' effort support #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/OsaurusCore/Models/ModelOptions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ struct OpenAIReasoningProfile: ModelProfile {
label: "Reasoning Effort",
icon: "brain",
kind: .segmented([
ModelOptionSegment(id: "minimal", label: "Minimal"),
ModelOptionSegment(id: "low", label: "Low"),
ModelOptionSegment(id: "medium", label: "Medium"),
ModelOptionSegment(id: "high", label: "High"),
Expand Down
23 changes: 15 additions & 8 deletions Packages/OsaurusCore/Services/RemoteProviderService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,22 +1351,26 @@ public actor RemoteProviderService: ToolCapableService {
tools: [Tool]?,
toolChoice: ToolChoiceOption?
) -> RemoteChatRequest {
let reasoning = parameters.modelOptions["reasoningEffort"]?.stringValue
.map { ReasoningConfig(effort: $0) }
let effortValue = parameters.modelOptions["reasoningEffort"]?.stringValue
let isOfficialOpenAI = provider.host.lowercased().contains("openai.com")
let isReasoningModel = OpenAIReasoningProfile.matches(modelId: model)

return RemoteChatRequest(
model: model,
messages: messages,
temperature: parameters.temperature,
// Reasoning models (o1, gpt-5) forbid temperature/top_p when reasoning is active as inferred from
// https://community.openai.com/t/gpt-5-nano-accepted-parameters/1355086/2
temperature: isReasoningModel ? nil : parameters.temperature,
max_completion_tokens: parameters.maxTokens,
stream: stream,
top_p: parameters.topPOverride,
top_p: isReasoningModel ? nil : parameters.topPOverride,
frequency_penalty: nil,
presence_penalty: nil,
stop: nil,
tools: tools,
tool_choice: toolChoice,
reasoning: reasoning,
reasoning_effort: effortValue,
reasoning: isOfficialOpenAI ? nil : effortValue.map { ReasoningConfig(effort: $0) },
modelOptions: parameters.modelOptions,
veniceParameters: buildVeniceParameters(from: parameters.modelOptions)
)
Expand Down Expand Up @@ -1798,13 +1802,15 @@ private struct RemoteChatRequest: Encodable {
var stop: [String]?
let tools: [Tool]?
let tool_choice: ToolChoiceOption?
let reasoning_effort: String?
let reasoning: ReasoningConfig?
let modelOptions: [String: ModelOptionValue]
let veniceParameters: VeniceParameters?

private enum CodingKeys: String, CodingKey {
case model, messages, temperature, max_completion_tokens, stream
case top_p, frequency_penalty, presence_penalty, stop, tools, tool_choice
case reasoning_effort
case reasoning
case veniceParameters = "venice_parameters"
}
Expand Down Expand Up @@ -2256,18 +2262,19 @@ private struct RemoteChatRequest: Encodable {
input = .items(inputItems)
}

let reasoning = modelOptions["reasoningEffort"]?.stringValue
let reasoning = reasoning_effort
.map { OpenResponsesReasoningConfig(effort: $0) }
let isReasoningModel = OpenAIReasoningProfile.matches(modelId: model)

return OpenResponsesRequest(
model: model,
input: input,
stream: stream,
tools: openResponsesTools,
tool_choice: openResponsesToolChoice,
temperature: temperature,
temperature: isReasoningModel ? nil : temperature,
max_output_tokens: max_completion_tokens,
top_p: top_p,
top_p: isReasoningModel ? nil : top_p,
instructions: instructions,
previous_response_id: nil,
metadata: nil,
Expand Down
Loading