Skip to content

OSAC-496: Pass shared tenant on hub create#279

Closed
tchughesiv wants to merge 1 commit into
osac-project:mainfrom
tchughesiv:OSAC-496-hub-create-tenant
Closed

OSAC-496: Pass shared tenant on hub create#279
tchughesiv wants to merge 1 commit into
osac-project:mainfrom
tchughesiv:OSAC-496-hub-create-tenant

Conversation

@tchughesiv

@tchughesiv tchughesiv commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass --tenant shared in prepare-fulfillment-service.sh when registering the hub (admin token has universal tenant access after OSAC-496)
  • Document the --tenant flag in OSAC-CLI-HOWTO.md (CLI also defaults to shared when omitted)

Jira

https://redhat.atlassian.net/browse/OSAC-496

Related PRs

Test plan

  • bash scripts/kustomize-build-all.sh — pass
  • CI (if applicable)

Pass --tenant shared in prepare-fulfillment-service.sh for admin hub
registration after explicit tenant became required. Document the flag in
OSAC-CLI-HOWTO.md (CLI also defaults to shared when omitted).
@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown

@tchughesiv: This pull request references OSAC-496 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Pass --tenant shared in prepare-fulfillment-service.sh when registering the hub (admin token has universal tenant access after OSAC-496)
  • Document the --tenant flag in OSAC-CLI-HOWTO.md (CLI also defaults to shared when omitted)

Jira

https://redhat.atlassian.net/browse/OSAC-496

Related PRs

Test plan

  • bash scripts/kustomize-build-all.sh — pass
  • CI (if applicable)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from danmanor and jhernand June 15, 2026 20:44
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tchughesiv
Once this PR has been reviewed and has the lgtm label, please assign eliorerz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tchughesiv, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 28 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 6522cd0d-7543-493f-9341-e41521b03782

📥 Commits

Reviewing files that changed from the base of the PR and between 8adc5ad and 8612671.

📒 Files selected for processing (2)
  • OSAC-CLI-HOWTO.md
  • scripts/prepare-fulfillment-service.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tchughesiv

tchughesiv commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Closing as unnecessary: fulfillment-service #704 adds --tenant on osac create hub with default shared, so the installer script and HOWTO changes here are redundant for correctness. OSAC-496 is covered by fulfillment-service #704 and osac-operator #297.

@tchughesiv tchughesiv closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants