Skip to content

OSAC-240: Add describe networkclass CLI command and update #701

Open
SiddarthR56 wants to merge 1 commit into
osac-project:mainfrom
SiddarthR56:osac-240
Open

OSAC-240: Add describe networkclass CLI command and update #701
SiddarthR56 wants to merge 1 commit into
osac-project:mainfrom
SiddarthR56:osac-240

Conversation

@SiddarthR56

Copy link
Copy Markdown
Contributor

Summary

  • Add describe networkclass CLI subcommand with tabwriter output showing all NetworkClass fields (ID, name, title, description, capabilities, default, state, message)
  • Update get networkclass table YAML to include description and per-capability (IPv4/IPv6/Dual-Stack) columns alongside existing ID, name, title, and default columns
  • Register networkclass in the describe command tree with alias networkclasses and add corresponding test coverage (8 rendering tests + parent registration tests)

…with description/capabilities columns

 Assisted-by: Cursor/Claude
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@SiddarthR56, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 7 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: a885f208-1eaa-404b-a48e-e77c2a14fd13

📥 Commits

Reviewing files that changed from the base of the PR and between 79daf20 and 1362cdb.

📒 Files selected for processing (6)
  • internal/cmd/cli/describe/describe_cmd.go
  • internal/cmd/cli/describe/describe_cmd_test.go
  • internal/cmd/cli/describe/networkclass/describe_networkclass_cmd.go
  • internal/cmd/cli/describe/networkclass/describe_networkclass_suite_test.go
  • internal/cmd/cli/describe/networkclass/describe_networkclass_test.go
  • internal/rendering/tables/osac.public.v1.NetworkClass.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot

openshift-ci-robot commented Jun 15, 2026

Copy link
Copy Markdown

@SiddarthR56: This pull request references OSAC-240 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add describe networkclass CLI subcommand with tabwriter output showing all NetworkClass fields (ID, name, title, description, capabilities, default, state, message)
  • Update get networkclass table YAML to include description and per-capability (IPv4/IPv6/Dual-Stack) columns alongside existing ID, name, title, and default columns
  • Register networkclass in the describe command tree with alias networkclasses and add corresponding test coverage (8 rendering tests + parent registration tests)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SiddarthR56
Once this PR has been reviewed and has the lgtm label, please assign jhernand for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


client := publicv1.NewNetworkClassesClient(conn)

matched, err := lookup.Find(ref, "network class", lookup.FindOptions{IncludeDeleted: c.includeDeleted}, func(filter string, limit int32) ([]*publicv1.NetworkClass, error) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we mostly don't care about readability of code, but this is awfully long and difficult to read. Consider making it a bit better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants