NO-ISSUE: Add Helm build artifacts to .gitignore#700
Conversation
|
@eliorerz: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughTwo ChangesHelm Dependency Artifact Exclusion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| # Helm dependency build artifacts | ||
| charts/*/charts/ | ||
| charts/*/Chart.lock |
There was a problem hiding this comment.
I think this isn't needed because the only chart in this repository does not embed other dependent charts, and we don't have plan to change that.
Anyhow, it doesn't hurt. I'd appreciate if you can remove the comment and sort the lines ad keep the lines alphabetically sorted. It helps to avoid duplicates.
Summary
charts/*/charts/andcharts/*/Chart.lockto.gitignorehelm dependency buildand should not be trackedSummary by CodeRabbit