Skip to content

NO-ISSUE: Add Helm build artifacts to .gitignore#700

Open
eliorerz wants to merge 1 commit into
osac-project:mainfrom
eliorerz:fix/gitignore-helm-artifacts
Open

NO-ISSUE: Add Helm build artifacts to .gitignore#700
eliorerz wants to merge 1 commit into
osac-project:mainfrom
eliorerz:fix/gitignore-helm-artifacts

Conversation

@eliorerz

@eliorerz eliorerz commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add charts/*/charts/ and charts/*/Chart.lock to .gitignore
  • These are generated by helm dependency build and should not be tracked

Summary by CodeRabbit

  • Chores
    • Updated build configuration to ignore Helm dependency artifacts.

@openshift-ci-robot

Copy link
Copy Markdown

@eliorerz: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Add charts/*/charts/ and charts/*/Chart.lock to .gitignore
  • These are generated by helm dependency build and should not be tracked

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7ae0dd48-7982-4098-bcce-b91018c1b806

📥 Commits

Reviewing files that changed from the base of the PR and between 79daf20 and 56d827b.

📒 Files selected for processing (1)
  • .gitignore

Walkthrough

Two .gitignore entries are added under a new # Helm comment section to exclude Helm dependency build artifacts: the charts/*/charts/ directory and charts/*/Chart.lock file generated by helm dependency build.

Changes

Helm Dependency Artifact Exclusion

Layer / File(s) Summary
Helm build artifact ignore patterns
.gitignore
Adds a # Helm section with patterns to exclude charts/*/charts/ and charts/*/Chart.lock from version control, preventing Helm dependency build outputs from being committed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

⚓ Severity: Informational — No secrets exposed, supply chain risk: negligible.
A lock file and a charts/ dir,
once lurking in commits with flair,
now banished by a .gitignore line,
Helm artifacts no longer mine
to accidentally push and share. 🛡️

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and concisely describes the main change: adding Helm build artifacts to .gitignore. It is clear, specific, and directly reflects the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed PR adds only standard .gitignore patterns for Helm artifacts with no hardcoded secrets, API keys, tokens, passwords, base64 credentials, or embedded URLs detected.
No-Weak-Crypto ✅ Passed PR only modifies .gitignore for Helm artifacts; contains zero code changes or cryptographic implementations to evaluate.
No-Injection-Vectors ✅ Passed .gitignore is a static configuration file with no executable code; injection vectors cannot exist in non-code configuration files.
Container-Privileges ✅ Passed Custom check for container privilege escalation is not applicable—PR only modifies .gitignore file, which cannot contain K8s/container manifests with privilege settings.
No-Sensitive-Data-In-Logs ✅ Passed PR modifies only .gitignore with Helm artifact ignore patterns; no logging code or sensitive data exposure present.
Ai-Attribution ✅ Passed No AI tool usage disclosed in PR description or commit message; no attribution trailers required. The "AI-generated summary" is meta-metadata, not evidence of contributor AI usage.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread .gitignore

# Helm dependency build artifacts
charts/*/charts/
charts/*/Chart.lock

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't needed because the only chart in this repository does not embed other dependent charts, and we don't have plan to change that.

Anyhow, it doesn't hurt. I'd appreciate if you can remove the comment and sort the lines ad keep the lines alphabetically sorted. It helps to avoid duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants