OSAC-1449: Add fabric_manager and k8s_manager fields to NetworkClass proto#699
Conversation
…proto Add fabric_manager (string) and k8s_manager (optional string) to the NetworkClass message in both public and private API definitions. These fields identify which managers handle physical fabric operations and K8s-to-fabric bridging for each network class. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Dan Manor <dmanor@redhat.com>
|
@danmanor: This pull request references OSAC-1449 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Warning Review limit reached
More reviews will be available in 46 minutes and 44 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| // Identifier of the K8s manager that bridges the Kubernetes overlay to the physical fabric. Only needed for regions | ||
| // that host VMs — the K8s manager creates the overlay network on hosting clusters and bridges it to the fabric | ||
| // segment. For example: "cudn_localnet". If not set, the region does not support VM workloads. | ||
| optional string k8s_manager = 11; |
There was a problem hiding this comment.
What is the user of the API going to do with these fields? I think they don't belong in the public API. Consider having them only in the private API.
…lass API These are implementation details for admins, not tenant-facing fields. Keep them only in the private API. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Dan Manor <dmanor@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor, jhernand The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
OSAC-1449: Add fabric_manager and k8s_manager fields to NetworkClass protoJira: https://redhat.atlassian.net/browse/OSAC-1449
Epic:
OSAC-1438— NetworkClass Two-Manager ModelSummary
Adds
fabric_manager(string) andk8s_manager(optional string) fields to the NetworkClassmessage in both public and private API proto definitions. These fields identify which managers
handle physical fabric operations and K8s-to-fabric bridging for each network class, as described
in the unified-networking enhancement proposal.
Changes
proto/private/osac/private/v1/network_class_type.proto— addedfabric_manager(field 10) andk8s_manager(field 11) to privateNetworkClassmessageproto/public/osac/public/v1/network_class_type.proto— added matching fields to publicNetworkClassmessageinternal/api/— regenerated Go code viabuf generateTesting
internal/serverspass.buf lint,uv run dev.py lint,ginkgo run -r internalall passAcceptance Criteria
fabric_manager(string) field to NetworkClass proto in both public and private APIsk8s_manager(optional string) field to NetworkClass proto in both public and private APIsbuf generatebuf lintpasses