Skip to content

NO-ISSUE: Consolidate CI setup into a single setup-dev action #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhernand wants to merge 1 commit into
base: main
Choose a base branch
from
+35 −42
Open

NO-ISSUE: Consolidate CI setup into a single setup-dev action #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions .github/actions/setup-go/action.yaml → .github/actions/setup-dev/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright (c) 2025 Red Hat Inc.
# Copyright (c) 2026 Red Hat Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
# in compliance with the License. You may obtain a copy of the License at
Expand All @@ -12,17 +12,17 @@
# the License.
#

name: Setup Go
description: Install and Go and Ginkgo
name: Setup development tools

@coderabbitai coderabbitai Bot Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Action metadata missing required description field.

The description field was removed when updating the action name. GitHub Actions metadata requires both name and description for proper documentation and discoverability. Risk: Medium – violates action metadata schema and impedes maintainability.

📝 Proposed fix 
 name: Setup development tools
+description: Setup Go, Python, and project-specific development tools with caching
 runs:
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
name: Setup development tools
name: Setup development tools
description: Setup Go, Python, and project-specific development tools with caching
runs:
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/actions/setup-dev/action.yaml at line 15, The action metadata is
missing the required description field; update the action metadata in
action.yaml to include a top-level description key alongside name (e.g., add a
descriptive string under the description property) so the metadata meets GitHub
Actions schema and improves discoverability; ensure the description succinctly
explains the purpose of "Setup development tools" and is a plain string value at
the same level as name.

Source: Coding guidelines

runs:
using: composite
steps:

# Go and Ginkgo:
- uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
with:
go-version: '1.26.2'
- shell: bash
run: |
go mod download
run: go mod download
- id: ginkgo-cache
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5
with:
Expand All @@ -34,3 +34,25 @@ runs:
module="github.com/onsi/ginkgo/v2"
version=$(go list -f '{{ .Version }}' -m "${module}")
go install "${module}/ginkgo@${version}"

# Python, uv, and ruff:
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
with:
python-version: '3.14'
- uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0
- shell: bash
run: uv tool install ruff==0.15.16

# Project-specific tools installed by 'dev.py'. The cache key includes the hash of 'dev/tools.py'
# because that file defines the tool names, versions, and checksums. Any change there means
# different binaries should be installed.
- id: dev-cache
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5
with:
key: dev-${{ runner.os }}-${{ hashFiles('dev/tools.py') }}
path: bin
- if: steps.dev-cache.outputs.cache-hit != 'true'
shell: bash
run: uv run dev.py setup
- shell: bash
run: echo "${GITHUB_WORKSPACE}/bin" >> "${GITHUB_PATH}"
25 changes: 0 additions & 25 deletions .github/actions/setup-python/action.yaml
View file
Open in desktop

This file was deleted.

20 changes: 8 additions & 12 deletions .github/workflows/check-pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
with:
persist-credentials: false
- uses: ./.github/actions/setup-python
- uses: ./.github/actions/setup-dev
- run: uv run ruff check

check-go-code:
Expand All @@ -53,11 +53,8 @@ jobs:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
with:
persist-credentials: false
- uses: ./.github/actions/setup-go
- uses: ./.github/actions/setup-python
- run: |
uv run dev.py setup
uv run dev.py lint
- uses: ./.github/actions/setup-dev
- run: uv run dev.py lint

check-generated-code:
name: Check generated code
Expand All @@ -81,9 +78,8 @@ jobs:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
with:
persist-credentials: false
- uses: ./.github/actions/setup-go
- run: |
ginkgo run --timeout 1h -r internal
- uses: ./.github/actions/setup-dev
- run: ginkgo run --timeout 1h -r internal

build-binaries:
name: Build binaries
Expand All @@ -92,7 +88,7 @@ jobs:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
with:
persist-credentials: false
- uses: ./.github/actions/setup-go
- uses: ./.github/actions/setup-dev
- uses: goreleaser/goreleaser-action@5daf1e915a5f0af01ddbcd89a43b8061ff4f1a89 # v7
with:
args: build --snapshot --clean
Expand All @@ -104,7 +100,7 @@ jobs:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
with:
persist-credentials: false
- uses: ./.github/actions/setup-go
- uses: ./.github/actions/setup-dev
- run: |
echo '127.0.0.1 fulfillment-api.osac.svc.cluster.local' | sudo tee -a /etc/hosts
echo '127.0.0.1 fulfillment-internal-api.osac.svc.cluster.local' | sudo tee -a /etc/hosts
Expand All @@ -124,7 +120,7 @@ jobs:
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
with:
persist-credentials: false
- uses: ./.github/actions/setup-go
- uses: ./.github/actions/setup-dev
- run: |
echo '127.0.0.1 fulfillment-api.osac.svc.cluster.local' | sudo tee -a /etc/hosts
echo '127.0.0.1 fulfillment-internal-api.osac.svc.cluster.local' | sudo tee -a /etc/hosts
Expand Down
Loading