Code

WIP - Bash code review#209

Code

Draft

ingydotnet wants to merge 15 commits intoos-autoinst:masteros-autoinst/scripts:masterfrom ingydotnet:masteringydotnet/os-autoinst-scripts:masterCopy head branch name to clipboard

+240-164

Commits

Commits on Jan 30, 2023

• WIP - Bash code review - first commit

  Show description for 52e69a3
  ingydotnet

  committed
  52e69a3

  Copy full SHA for 52e69a3

• Add a run-with Makefile function

  Show description for 2154a43
  ingydotnet

  committed
  2154a43

  Copy full SHA for 2154a43

• Define and use a die function

  Show description for 347ada5
  ingydotnet

  committed
  347ada5

  Copy full SHA for 347ada5

• Various ways to split long lines in Bash

  Show description for 702badc
  ingydotnet

  committed
  702badc

  Copy full SHA for 702badc

• Better use of [[ ... ]]

  Show description for 66cff34
  ingydotnet

  committed
  66cff34

  Copy full SHA for 66cff34

• Use the x() (...) function form

  Show description for 6afe96e
  ingydotnet

  committed
  6afe96e

  Copy full SHA for 6afe96e

• Simplify logic in a function

  Show description for 2b321d8
  ingydotnet

  committed
  2b321d8

  Copy full SHA for 2b321d8

• Refactor a couple functions in _common

  Show description for 4eda8b3
  ingydotnet

  committed
  4eda8b3

  Copy full SHA for 4eda8b3

• Avoid echo ... | ...

  Show description for 3ffb566
  ingydotnet

  committed
  3ffb566

  Copy full SHA for 3ffb566

• Change run-with function to error instead of warn

  Show description for 0df634b
  ingydotnet

  committed
  0df634b

  Copy full SHA for 0df634b

• Make the bpan and venv setups less noisy

  ingydotnet

  committed
  758b8a2

  Copy full SHA for 758b8a2

• Changes to Bash bootstrapping code

  Show description for c04beaa
  ingydotnet

  committed
  c04beaa

  Copy full SHA for c04beaa

• Fix shellcheck for Bash test files

  Show description for ffacfa1
  ingydotnet

  committed
  ffacfa1

  Copy full SHA for ffacfa1

• Remove useless quotes on assignments

  Show description for 983e105
  ingydotnet

  committed
  983e105

  Copy full SHA for 983e105

Commits on Jan 31, 2023

• Use 'source' instead of '.'

  Show description for 4a01a16
  ingydotnet

  committed
  4a01a16

  Copy full SHA for 4a01a16