-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use podman everywhere #85
base: master
Are you sure you want to change the base?
Conversation
2c858a1
to
7b4d00b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change but I would like to see a proof that this works.
79c0f49
to
5847ea1
Compare
It works, but I wonder why podman build times out so easily. Is this normal and just hidden behind retries? There's a timeout of 3600 and it seems to simply take longer getting all of the packages installed. |
assert_script_run("for i in {1..3}; do docker run --rm -d --network testing -e POSTGRES_PASSWORD=openqa -e POSTGRES_USER=openqa -e POSTGRES_DB=openqa --net-alias=db --name db postgres && break; done", timeout => 600); | ||
wait_for_container_log("db", "database system is ready to accept connections", "docker"); | ||
assert_script_run($self->{cre} . " network create testing"); | ||
assert_script_run($self->{cre} . " run --rm -d --network testing -e POSTGRES_PASSWORD=openqa -e POSTGRES_USER=openqa -e POSTGRES_DB=openqa --network-alias=db --name db docker.io/library/postgres:latest", timeout => 600); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems you are reverting the retrying you added just recently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see it in the diff, but likely this was a timeout I mistakenly added when I didn't know where it was timing out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But … you removed the retrying, see the diff please. The for i in {1..3}; …
is gone
We already use it in some but not in other cases. Being explicit avoids surprises and stops podman from asking to choose one. See also os-autoinst/os-autoinst-distri-openQA#85
5847ea1
to
552d068
Compare
assert_script_run("for i in {1..3}; do docker run --rm -d --network testing -e POSTGRES_PASSWORD=openqa -e POSTGRES_USER=openqa -e POSTGRES_DB=openqa --net-alias=db --name db postgres && break; done", timeout => 600); | ||
wait_for_container_log("db", "database system is ready to accept connections", "docker"); | ||
assert_script_run($self->{cre} . " network create testing"); | ||
assert_script_run($self->{cre} . " run --rm -d --network testing -e POSTGRES_PASSWORD=openqa -e POSTGRES_USER=openqa -e POSTGRES_DB=openqa --network-alias=db --name db docker.io/library/postgres:latest", timeout => 600); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But … you removed the retrying, see the diff please. The for i in {1..3}; …
is gone
This pull request is now in conflicts. Could you fix it? 🙏 |
2 similar comments
This pull request is now in conflicts. Could you fix it? 🙏 |
This pull request is now in conflicts. Could you fix it? 🙏 |
Inspired by: https://progress.opensuse.org/issues/110803