Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Freenode Policy from .perlcriticrc #56

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perlpunk
Copy link
Collaborator

@perlpunk perlpunk commented Jan 22, 2025

Package was renamed long ago

Edit: this has to wait until Perl::Critic::Community version 1.0.4 is everywhere

Package was renamed long ago
@perlpunk
Copy link
Collaborator Author

Not sure why the tests are failing. Locally I get:

tools/perlcritic --quiet .
::warning file=lib/OpenQA/Test/TimeLimit.pm,line=1,col=1,title=Missing strict or warnings - severity 4::[Community::StrictWarnings] The strict and warnings pragmas are important to avoid common pitfalls and deprecated/experimental functionality. Make sure each script or module contains "use strict; use warnings;" or a module that does this for you
...

but the config says it should accept Test::Most as a replacement for strict and warnings

[Community::StrictWarnings]
extra_importers = Test::Most

@perlpunk perlpunk marked this pull request as draft January 22, 2025 23:19
@perlpunk
Copy link
Collaborator Author

It seems like as long as the Freenode packages are still there (with version 1.0.3) the include strict ... line will automatically load both packages, so we need to specify the Test::Most exception for both, until version 1.0.4 is everywhere...
The Freenode in the config will simply be ignored in version 1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant