Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing captcha group #4254

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: add missing captcha group #4254

merged 1 commit into from
Dec 30, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 27, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr changed the title fix(sdk): add missing captcha group fix: add missing captcha group Dec 27, 2024
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we add some patches in the network client's patches? Or is this for the standalone Kratos client? Otherwise LGTM.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (c4b3dd6) to head (ea10c25).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4254      +/-   ##
==========================================
+ Coverage   78.59%   78.61%   +0.01%     
==========================================
  Files         381      381              
  Lines       27372    27372              
==========================================
+ Hits        21513    21518       +5     
+ Misses       4237     4233       -4     
+ Partials     1622     1621       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr
Copy link
Member Author

aeneasr commented Dec 30, 2024

Didn't we add some patches in the network client's patches? Or is this for the standalone Kratos client? Otherwise LGTM.

According to a customer, the group was missing from the latest version of ory SDK

@aeneasr aeneasr merged commit 241111b into master Dec 30, 2024
29 checks passed
@aeneasr aeneasr deleted the add-captcha-group branch December 30, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants