Skip to content

Conversation

@mitar
Copy link
Contributor

@mitar mitar commented Jun 24, 2025

Related Issue or Design Document

We use memory store for tests and we noticed race conditions failing those tests occasionally. It looks like locking was not correct in memory store.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@mitar mitar requested review from a team and aeneasr as code owners June 24, 2025 22:03
@mitar
Copy link
Contributor Author

mitar commented Jun 25, 2025

OIDC Conformity Tests have timed out. I do not think this is because of this PR.

@aeneasr
Copy link
Member

aeneasr commented Jun 25, 2025

Hm, CI timeout usually means some test(s) failed. But yeah, strange why they fail. Mabye re-running helps

@mitar
Copy link
Contributor Author

mitar commented Jun 25, 2025

@aeneasr It does not seem I have permissions to do a re-run?

@mitar
Copy link
Contributor Author

mitar commented Jun 26, 2025

@alnr Thanks for re-run.

I think this is a bug in current testing suite, also unrelated #854 is failing with exactly the same "Test was INTERRUPTED" errors while testing, and then test harness tries to repeat the test, again and again. And this is why the whole run then timeouts.

So I think somebody should try to run CI on the master branch and fix it there first.

@mitar mitar force-pushed the fix-memory-locking branch from 4cf2e41 to e8d0721 Compare July 1, 2025 11:55
@mitar
Copy link
Contributor Author

mitar commented Jul 1, 2025

@aeneasr CI is now passing. Feel free to merge. :-)

@aeneasr aeneasr merged commit 35ebb05 into ory:master Jul 1, 2025
5 checks passed
@aeneasr
Copy link
Member

aeneasr commented Jul 1, 2025

Thanks!

mitar added a commit to charon/charon that referenced this pull request Aug 19, 2025
This fixes race errors in tests.

See: ory/fosite#856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants