Skip to content

Commit

Permalink
Aligning dependencies between Gemfile and the gemspec.
Browse files Browse the repository at this point in the history
It's unfortunate that the gemspec and Gemfile was out of sync, one
listed canonix as a dependency, another xmlcanonicalizer.

Tests pass with this commit and future changes should stick to
modifying the gemspec unless you for some good reason need e.g.
bundler groups or platform restrictions.
  • Loading branch information
morten committed May 11, 2012
1 parent 9067278 commit 573cad3
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 36 deletions.
7 changes: 1 addition & 6 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
source 'http://rubygems.org'

gem 'rake'
gem 'shoulda', "~>3.0.1"
gem 'mocha', "~>0.10.5"
gem 'ruby-debug', "~>0.10.4"
gem 'uuid', "~>2.3.5"
gem 'xmlcanonicalizer', "~>0.1.1"
gemspec
20 changes: 13 additions & 7 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
PATH
remote: .
specs:
ruby-saml (0.5.3)
canonix (= 0.1.1)
uuid (~> 2.3)

GEM
remote: http://rubygems.org/
specs:
canonix (0.1.1)
columnize (0.3.6)
linecache (0.46)
rbx-require-relative (> 0.0.4)
Expand All @@ -9,7 +17,7 @@ GEM
metaclass (0.0.1)
mocha (0.10.5)
metaclass (~> 0.0.1)
rake (0.8.7)
rake (0.9.2.2)
rbx-require-relative (0.0.9)
ruby-debug (0.10.4)
columnize (>= 0.1)
Expand All @@ -24,15 +32,13 @@ GEM
systemu (2.5.0)
uuid (2.3.5)
macaddr (~> 1.0)
xmlcanonicalizer (0.1.1)

PLATFORMS
ruby

DEPENDENCIES
mocha (~> 0.10.5)
mocha
rake
ruby-debug (~> 0.10.4)
shoulda (~> 3.0.1)
uuid (~> 2.3.5)
xmlcanonicalizer (~> 0.1.1)
ruby-debug
ruby-saml!
shoulda
29 changes: 6 additions & 23 deletions ruby-saml.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,29 +23,12 @@ Gem::Specification.new do |s|
s.summary = %q{SAML Ruby Tookit}
s.test_files = `git ls-files test/*`.split("\n")

if s.respond_to? :specification_version then
current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
s.specification_version = 3
s.add_runtime_dependency("canonix", ["0.1.1"])
s.add_runtime_dependency("uuid", ["~> 2.3"])

if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
s.add_runtime_dependency(%q<canonix>, ["~> 0.1"])
s.add_runtime_dependency(%q<uuid>, ["~> 2.3"])
s.add_development_dependency(%q<shoulda>, [">= 0"])
s.add_development_dependency(%q<ruby-debug>, [">= 0"])
s.add_development_dependency(%q<mocha>, [">= 0"])
else
s.add_dependency(%q<canonix>, ["~> 0.1"])
s.add_dependency(%q<uuid>, ["~> 2.3"])
s.add_dependency(%q<shoulda>, [">= 0"])
s.add_dependency(%q<ruby-debug>, [">= 0"])
s.add_dependency(%q<mocha>, [">= 0"])
end
else
s.add_dependency(%q<canonix>, ["~> 0.1"])
s.add_dependency(%q<uuid>, ["~> 2.3"])
s.add_dependency(%q<shoulda>, [">= 0"])
s.add_dependency(%q<ruby-debug>, [">= 0"])
s.add_dependency(%q<mocha>, [">= 0"])
end
s.add_development_dependency("shoulda", [">= 0"])
s.add_development_dependency("rake", [">= 0"])
s.add_development_dependency("ruby-debug", [">= 0"])
s.add_development_dependency("mocha", [">= 0"])
end

0 comments on commit 573cad3

Please sign in to comment.