Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade timm #89

Merged
merged 31 commits into from
Jan 11, 2024
Merged

Upgrade timm #89

merged 31 commits into from
Jan 11, 2024

Conversation

lorenzomammana
Copy link
Contributor

@lorenzomammana lorenzomammana commented Jan 8, 2024 •
edited
Loading

Summary

This PR aims to upgrade the outdated timm version with the most recent one -> 0.9.12

It contains also some fixes for half precision related model export and some inclusion of new output files for both sklearn based tasks and anomaly detection.

The changelog is the following

Added

  • Add new backbones for classification
  • Add parameter to save a model summary for sklearn based classification tasks
  • Add results csv file for anomaly detection task
  • Add a way to freeze backbone layers by index for the finetuning task

Updated

  • Update timm requirements to 0.9.12

Fixed

  • Fix ModelSignatureWrapper not returing the correct instance when cpu, to and half functions are called
  • Fix failure in model logging on mlflow whe half precision is used

Type of Change

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

lorenzomammana and others added 23 commits January 2, 2024 10:22
@lorenzomammana
refactor: Refactor import after timm upgrade
928660f
@lorenzomammana
fix: Fix classification test performed on cpu after model export
9e933a0
@lorenzomammana
build: Update timm version
531f7f3
@lorenzomammana
feat: Add freezing layer by index capability for classification task
24f18f0
@AlessandroPolidori
feat: Save csv file with test results in anomaly train task (#87)
b28e150 
* feat: Save csv file with test results in anomaly train task

* fix: Filter samples to remove ones from .ipynb_checkpoint hidden dirs

* fix: Change anomaly results column names using snake_case
@lorenzomammana
refactor: Use torchvision weights for resnet18
a70f830
@lorenzomammana
refactor: Remove hardcoded precision
8117a9d
@lorenzomammana
feat: Fix ModelSignatureWrapper not returning the correct isntance on…
aca359c 
… certain function calls
@lorenzomammana
feat: ModelSignatureWrapper now saves also the model summary to disk,…
9a34135 
… fix cpu not returning the correct instance
@lorenzomammana
build: Add torchinfo to requirements
36c15ba
@AlessandroPolidori
libs: Updgrade anomalib to 0.7.0+1.2.8
107bab3
@lorenzomammana
feat: Add model summary generation for sklearn based tasks
acafd9c
@AlessandroPolidori
fix: mlflow model half precision
8546879
@AlessandroPolidori
Merge branch 'feature/upgrade-timm' into feat/AIG-1972-fp16-bugfix
5a9a233
@lorenzomammana
build: Update timm version and smp requirements
1b682c6
@lorenzomammana
build: Bump version 1.3.8 -> 1.4.0
ba0d0ab
@AlessandroPolidori
fix: Better fp16 check in finish()
fa89cb2
@lorenzomammana
build: Update timm commit pointer to use timm 0.9.12
f885968
@lorenzomammana
feat: Add new timm backbones
0dab1de
@AlessandroPolidori
Merge feature/upgrade-timm
ba3b858
@AlessandroPolidori
Merge pull request #88 from orobix/feat/AIG-1972-fp16-bugfix
00a8875 
Fp16 bugfix
@AlessandroPolidori
add: Use old resnet18 weights as default anomalib backbone in padim/p…
bcbe7e3 
…atchcore
@lorenzomammana
docs: Update changelog
6352163
@lorenzomammana lorenzomammana marked this pull request as ready for review January 8, 2024 16:50
@lorenzomammana lorenzomammana added the enhancement New feature or request label Jan 9, 2024
rcmalli
rcmalli reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@rcmalli rcmalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is okay after comments are resolved.

@AlessandroPolidori AlessandroPolidori merged commit a1fd7d8 into main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmalli rcmalli rcmalli approved these changes

@AlessandroPolidori AlessandroPolidori AlessandroPolidori approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorenzomammana @rcmalli @AlessandroPolidori