Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove opencv python #128

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

lorenzomammana
Copy link
Contributor

Summary

This PR aims to remove the "opencv-python" dependency in favor of the headless version. This is done as installing both is

  1. Not correct
  2. Problematic on Windows as the two packages might conflict

Type of Change

Please select the one relevant option below:

  • Refactor

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@lorenzomammana lorenzomammana self-assigned this Aug 19, 2024
@lorenzomammana lorenzomammana requested a review from rcmalli August 19, 2024 10:36
@lorenzomammana lorenzomammana merged commit 1c4e417 into main Aug 20, 2024
2 checks passed
@lorenzomammana lorenzomammana deleted the feature/remove-opencv-python branch August 20, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants