feat add overloads for field types to improve type safety - #1491
Merged
collerek merged 8 commits intoJan 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1491 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 207 207
Lines 14872 14878 +6
=========================================
+ Hits 14872 14878 +6
🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 21.68%
Performance Changes
Comparing |
Contributor
Author
|
Hi @collerek, I'd be interested in having this PR merged in soon as this issue has been affecting me since 2024 - what do we need to do to make sure that this suitable for merging? |
collerek
reviewed
Jan 27, 2026
collerek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the pr, one small comment
collerek
approved these changes
Jan 28, 2026
Collaborator
|
Awesome, thanks for the contribution <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to provide appropriate PyRight type overloads so that models provide the correct typing.
This will resolve errors related to this issue.
Sample model I made to validate this:
all_types_model.py
Sample of the errors highlighted in the IDE:

Output after running a migration:
migration_without_new_stubs.py
Sample of the errors being gone with the new stubs:

Output after running a new migration with the stubs present:
migration_with_new_stubs.py
Diff between the two migrations (only difference being the revision hash):
All this goes to show that the stub types do not impact the generation of the migration, only affecting the types used by the PyRight, preventing the need to add many
#type: ignoreor otherwise being forced to deal with red squigglies across the models.