Skip to content

More appropriate log levels#7

Open
lukas-krecan wants to merge 1 commit intooridool:masterfrom
productboard:log-levels
Open

More appropriate log levels#7
lukas-krecan wants to merge 1 commit intooridool:masterfrom
productboard:log-levels

Conversation

@lukas-krecan
Copy link

@lukas-krecan lukas-krecan commented Dec 12, 2022

Warning usually means that something went wrong

@oridool
Copy link
Owner

oridool commented Dec 12, 2022

@lukas-krecan - thanks for this PR.
However, I prefer to keep the log level as it is (Warning).
Most applications are running by default on log level warning. And those logs coming from this library are only written once, upon startup. I prefer seeing those to know everything was ok on startup. Changing to info level will omit those startup logs.

If you want, you can always customize the log level externally for the specific class/package by using system property (or application.yml in SpringBoot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants