Add Posterize option to LTCGI Diffuse

[fundale]

No description provided.

[orels1]

Hmm, I'm not really sure I want to add a branch just for this 🤔
Especially in the LTCGI module that also gets used by world shaders.

The v2 of the toon shader (which is what I assume this is meant to be used with) could probably support an extra spot where you posterize the LTCGI results in its own module.

However, thinking about it some more it feels like doing something like using the Toon Ramp and other shading settings might be what you actually want? Then instead of just pure posterization with discrete steps - you could have full ramp-based control over how the diffuse shading from LTCGI is applied? 🤔

[fundale]

Hmm, I'm not really sure I want to add a branch just for this 🤔 Especially in the LTCGI module that also gets used by world shaders.

The v2 of the toon shader (which is what I assume this is meant to be used with) could probably support an extra spot where you posterize the LTCGI results in its own module.

However, thinking about it some more it feels like doing something like using the Toon Ramp and other shading settings might be what you actually want? Then instead of just pure posterization with discrete steps - you could have full ramp-based control over how the diffuse shading from LTCGI is applied? 🤔

In a separate LTCGI module, or using a compiler directive in the current one?
I could see having a separate LTCGI module for Toon could be useful for adding more post effects or configuration to the LTCGI Toon module.

I hadn't really considered a Toon Ramp, though that could be useful and easier to customize.

And yes this effect is primarily for LTCGI on Toon, aiming to make it look more "Toony" to fit with the aesthetic.

[orels1]

In a separate LTCGI module, or using a compiler directive in the current one?

Probably a separate module
So with how v2 toon is set up - every lighting calculation is powered by the module itself, since the Toon shader is essentially just a collection of loosely connected effects.

So for this kinda thing i could imagine LTCGI putting data into something like
half3 customGIDiffuse and half3 customGISpecular, so then you can define your module that runs late which then modifies those in some way. Before the shader lighting model composites them all together

[fundale]

Gave Toon it's own LTCGI module with Texture Ramp support.
Tried messing around with customGIDiffuse and customGISpecular however they appear to only function in a baked state

[orels1]

oh I meant that I could set up something like that for the 2.0 version, not the current one

[fundale]

The customGI* or the Ramping / separate module?

[orels1]

the customGI part

[fundale]

Ah ok

[orels1]

The v7.0.0-dev.8 of the shaders now has support for customGISpecular and customGIDiffuse which you can access via %CustomGI functions, similar to how LTCGI module did it on Dev already.

This is also supported by the Toon shader now.
I would recommend also adding a very high order number to the posterization module since you'd want it to always run last, e.g.

%CustomGI("LTCGICustomGIPosterize", 1000)
{
    void LTCGICustomGI(MeshData d, SurfaceData o, inout half3 customGISpecular, inout half3 customGIDiffuse)
    {
        // modify custom GI stuff before it gets composited with the rest of the lighting
    }
}

[fundale]

Updated the Toon LTCGI and CustomGI Ramp modules, thought having it as a separate module would become useful for providing Toon Ramping for other CustomGI FX (perhaps AreaLit and VRSLGI).

Also should I remove the LTCGI Toon module from V1?

[orels1]

Have you tested it in Toon v1? As I'm pretty sure toon v1 doesn't have any hook points for %CustomGIFunctions in the fragment function 🤔

[fundale]

I have not tested the V2 LTCGI Toon Module with V1 Toon,
I'll check and make sure the V1 LTCGI Toon module still works with V1 Toon

[fundale]

The V1 LTCGI Toon Module still functions with V1 Toon, using %Color however it doesn't work with %CustomGI

[orels1]

yeah, ok, that's about what I expected, as Toon v1 doesnt have %CustomGI hooks