This repository was archived by the owner on Oct 5, 2023. It is now read-only.
refactor: Replace EventEmitter with EventTarget#63
Open
saul-jb wants to merge 10 commits intoorbitdb-archive:mainfrom
Open
refactor: Replace EventEmitter with EventTarget#63saul-jb wants to merge 10 commits intoorbitdb-archive:mainfrom
saul-jb wants to merge 10 commits intoorbitdb-archive:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the NodeJS
EventEmitterwith the nativeEventTarget.EventEmitteris not native to a browser environment whereasEventTargetis in both NodeJS and browser environments, this change will mean theEventEmitterdoes not need to somehow be bundled in to work with browser environments increasing native cross-environment compatibility.This is how Libp2p, IPFS and related modules have an event system while maintaining browser compatibility.