fix: flatten admin dashboard payload to include id attribute#179
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes admin dashboard user links by preserving the user id in flattened student, adviser, and mentor payloads while keeping role-specific IDs under studentId, adviserId, and mentorId.
Changes:
- Adds shared flattening helpers for student, adviser, and mentor user payloads.
- Replaces duplicated password-removal/flattening logic in dashboard evaluation payload generation.
- Ensures flattened payloads include the user
idneeded for correct profile links.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to resolve the bug where the links of the student / adviser / mentor names are not correct (they point to a wrong user).
To replicate,
a. Click on administrator dashboard, and then click on any adviser, the hyperlink goes to another person's profile.
b. Click on the user (Kabir for example it goes to https://nusskylab-v2-dev.comp.nus.edu.sg/users/12660 instead of https://nusskylab-v2-dev.comp.nus.edu.sg/users/14969) which shows no user is found.