fix: prevent submission duplicate creation and return full response on update#177
Merged
Merged
Conversation
xGladiate
approved these changes
May 19, 2026
xGladiate
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Tested the changes locally and it is working as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent
500 Internal Server Errorwhen "Start" is clicked multiple times by checking for existing submissions before creatingInclude answers in PUT /api/submissions/:id response so the frontend can properly update submission status without requiring re-login
Problem
Two related bugs were reported on the evaluation dashboard:
Unique constraint failed on the fields: (
deadlineId,fromUserId,toProjectId)This locks the user out of the evaluation page until they sign out and back in.
Fix
createOneSubmission: Added a findFirstSubmission check before createUniqueSubmission. If a matching submission already exists, return it instead of attempting a duplicate insert.
updateOneSubmissionBySubmissionId: Added include: { answers: true } to the final findUniqueSubmission call so the response contains the full submission state.
Test plan (after deploying)
updatedAttimestamp is reflected in the UI after submission