chore: update command generator for versioned docs #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerryHowe
requested review from
asmitbm,
FeynmanZhou,
sajayantony,
shizhMSFT,
SteveLasker and
vsoch
as code owners
FeynmanZhou
reviewed
Jun 6, 2024
FeynmanZhou
reviewed
Jun 6, 2024
TerryHowe
force-pushed
the
fix-replace-script-for-versions
branch
from
acd359f to
15a77ab
Compare
|
@FeynmanZhou I removed the bug fix release from the script and added a way to map using bug fixes if necessary. Normally, the pages won't change during a release. |
TerryHowe
changed the title
qweeah
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
LGTM although IANAM. What if we are updating 1.1 and the content of version-latest is 2.1.1?
Better add some comments or documents on how versions-latest should be used, otherwise when someone need to refresh for a patch release, they need to read and understand below code in refresh-commands.sh
map_version() {
grep "$1" versions-latest || echo "$1.0"
}
1 task
qweeah
reviewed
Jun 19, 2024
Signed-off-by: Terry Howe <[email protected]>
TerryHowe
force-pushed
the
fix-replace-script-for-versions
branch
from
15a77ab to
dc74774
Compare
|
LGTM although IANAM. |
FeynmanZhou
reviewed
Jun 19, 2024
FeynmanZhou
approved these changes
Jun 20, 2024
TerryHowe
pushed a commit
to TerryHowe/oras-www
that referenced
this pull request
Jul 21, 2024
Created a mapping file in case we need to use a bug fix release to generate the docs. I don't think that will happen often. Signed-off-by: Terry Howe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a mapping file in case we need to use a bug fix release to generate the docs. I don't think that will happen often.