Skip to content

fix x-no-posted-writes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlevon wants to merge 1 commit into
base: vfio-user-dbfix
Choose a base branch
from
Open

fix x-no-posted-writes #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions hw/vfio/user.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,14 +1451,20 @@ static int vfio_user_region_write(VFIOProxy *proxy, uint8_t index, off_t offset,
uint32_t count, void *data, bool post)
{
VFIOUserRegionRW *msgp = NULL;
int flags = post ? VFIO_USER_NO_REPLY : 0;
int size = sizeof(*msgp) + count;
int flags;
int ret;

if (count > max_xfer_size) {
return -EINVAL;
}

if (proxy->flags & VFIO_PROXY_NO_POST) {
post = false;
}

flags = post ? VFIO_USER_NO_REPLY : 0;

msgp = g_malloc0(size);
vfio_user_request_msg(&msgp->hdr, VFIO_USER_REGION_WRITE, size, flags);
msgp->offset = offset;
Expand All @@ -1467,7 +1473,7 @@ static int vfio_user_region_write(VFIOProxy *proxy, uint8_t index, off_t offset,
memcpy(&msgp->data, data, count);

/* async send will free msg after it's sent */
if (post && !(proxy->flags & VFIO_PROXY_NO_POST)) {
if (post) {
vfio_user_send_async(proxy, &msgp->hdr, NULL);
return count;
}
Expand Down