Repository navigation
test: widen the ttl window for the Postgres at-rest cases - #533
Merged
Merged
Conversation
Both at-rest cases saved with a 0.3 s ttl and slept 0.4 s before asserting expiry. The first save on a fresh table also runs the DDL under the advisory lock and the expiry is stamped before it, so under CI load the row had already run out when the asserts read it back (seen on the 6.0.0 release PR: list() returned nothing). They now save with 1.5 s and wait 1.5 times that. Signed-off-by: Federico Kamelhar <federico.kamelhar@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestPostgresAtRest(both the adapter and the nativePgCheckpointercase) saved with a 0.3-second ttl and slept 0.4 seconds before asserting expiry. The first save on a fresh table also runs the DDL under the advisory lock, and the expiry is stamped before it, so under CI load the row had already run out when the asserts read it back; on the 6.0.0 release PRcp.list("t")returned nothing. Same cause and same remedy as #529: the cases now save with a 1.5-second ttl and wait 1.5 times that.Testing
Both cases ran three times in a row against a local PostgreSQL 17, all green; ruff clean. Test-only change.