Add support for Native Image JFR on Windows#13332
Open
roberttoyonaga wants to merge 2 commits intooracle:masterfrom
Open
Add support for Native Image JFR on Windows#13332roberttoyonaga wants to merge 2 commits intooracle:masterfrom
roberttoyonaga wants to merge 2 commits intooracle:masterfrom
Conversation
0a6ec62 to
1493046
Compare
1493046 to
acf3ca4
Compare
8a2c66a to
cfa5526
Compare
Collaborator
Author
|
The gate test I was unable to reproduce the problem on my machine with: |
Member
|
This looks good to me and I do have the tests green. I will check if I can fix that failing GitHub action gate check, which seems a configuration/test issue. |
Member
|
FYI, I am fixing up the wrongly wired GitHub action gate at #13349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a Windows implementation for
RawFileOperationSupportand enables JFR on Windows. New tests inRawFileOperationSupportTesthave been added.Related issue: #13184
More Details
WindowsRawFileOperationSupportallows JFR to write to chunk files. This is the main component that was missing and blocking Windows support.