Skip to content

Fix inference failure caused by improper handling of large chat templates #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Fix inference failure caused by improper handling of large chat templates #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ads/aqua/extension/model_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env python
# Copyright (c) 2024, 2025 Oracle and/or its affiliates.
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/

import json
from typing import Optional
from urllib.parse import urlparse

Expand Down Expand Up @@ -341,9 +341,13 @@ def get(self, model_id):
):
try:
oci_data_science_model = OCIDataScienceModel.from_id(model_id)
chat_template = oci_data_science_model.get_custom_metadata_artifact("chat_template")
chat_template = chat_template.decode("utf-8")

return self.finish(json.dumps({"chat_template": chat_template}))

except Exception as e:
raise HTTPError(404, f"Model not found for id: {model_id}. Details: {str(e)}")
return self.finish(oci_data_science_model.get_custom_metadata_artifact("chat_template"))
raise HTTPError(404, f"Failed to fetch chat template for model_id={model_id}. Details: {str(e)}")

raise HTTPError(400, f"The request {self.request.path} is invalid.")

Expand Down
9 changes: 6 additions & 3 deletions tests/unitary/with_extras/aqua/test_model_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# -*- coding: utf-8 -*--
# Copyright (c) 2024, 2025 Oracle and/or its affiliates.
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
import json
from unicodedata import category
from unittest import TestCase
from unittest.mock import MagicMock, patch, ANY
Expand Down Expand Up @@ -272,11 +273,13 @@ def test_get_valid_path(self, mock_urlparse, mock_from_id):
mock_urlparse.return_value = request_path

model_mock = MagicMock()
model_mock.get_custom_metadata_artifact.return_value = "chat_template_string"
model_mock.get_custom_metadata_artifact.return_value = b"chat_template_string"
mock_from_id.return_value = model_mock

self.model_chat_template_handler.get(model_id="test_model_id")
self.model_chat_template_handler.finish.assert_called_with("chat_template_string")
self.model_chat_template_handler.finish.assert_called_with(
json.dumps({"chat_template": "chat_template_string"})
)
model_mock.get_custom_metadata_artifact.assert_called_with("chat_template")

@patch("ads.aqua.extension.model_handler.urlparse")
Expand Down Expand Up @@ -361,7 +364,7 @@ def test_post_model_not_found(self, mock_write_error, mock_from_id):
_, exc_instance, _ = exc_info
assert isinstance(exc_instance, HTTPError)
assert exc_instance.status_code == 404
assert "Model not found" in str(exc_instance)
assert "Model not found for id" in str(exc_instance)


class TestAquaHuggingFaceHandler:
Expand Down