Skip to content

[AQUA] Fixing List Model deployment call when model groups are present #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 10, 2025
Merged

[AQUA] Fixing List Model deployment call when model groups are present #1222

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5a65bb
Skip aqua deployments that are created from model group.
lu-ohai Jun 27, 2025
c7318aa
Fixing LIST MD AQUA call
kumar-shivam-ranjan Jul 10, 2025
4ada401
Resolving conflicts
kumar-shivam-ranjan Jul 10, 2025
fcfd0b8
Fixing MD list call
kumar-shivam-ranjan Jul 10, 2025
a67c7cc
Fixing MD list call
kumar-shivam-ranjan Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ads/aqua/modeldeployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,14 +867,17 @@ def list(self, **kwargs) -> List["AquaDeployment"]:
aqua_model_id = model_deployment.freeform_tags.get(
Tags.AQUA_MODEL_ID_TAG, UNKNOWN
)
if "datasciencemodelgroup" in aqua_model_id:
if (
"datasciencemodelgroup" in aqua_model_id
or model_deployment.model_deployment_configuration_details.deployment_type
== "UNKNOWN_ENUM_VALUE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we define a constant please. Also an inline comment on what this check means

):
continue
results.append(
AquaDeployment.from_oci_model_deployment(
model_deployment, self.region
)
)

# log telemetry if MD is in active or failed state
deployment_id = model_deployment.id
state = model_deployment.lifecycle_state.upper()
Expand Down
Loading