[FSSDK-11101] refactor handling of no config availability #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaed-optimizely
approved these changes
Feb 3, 2025
Contributor
junaed-optimizely
left a comment
junaed-optimizely
left a comment
There was a problem hiding this comment.
LGTM! Just few suggestions
lib/optimizely/index.ts
Outdated
|
|
||
| if (!this.isValidInstance()) { | ||
| this.logger?.error(INVALID_OBJECT, 'track'); | ||
| const configObj = this.projectConfigManager.getConfig(); |
lib/optimizely/index.ts
Outdated
| try { | ||
| if (!this.isValidInstance()) { | ||
| this.logger?.error(INVALID_OBJECT, 'getVariation'); | ||
| const configObj = this.projectConfigManager.getConfig(); |
lib/optimizely/index.ts
Outdated
| try { | ||
| if (!this.isValidInstance()) { | ||
| this.logger?.error(INVALID_OBJECT, 'isFeatureEnabled'); | ||
| const configObj = this.projectConfigManager.getConfig(); |
lib/optimizely/index.ts
Outdated
| } | ||
|
|
||
| if (!this.validateInputs({ user_id: userId })) { | ||
| const configObj = this.projectConfigManager.getConfig(); |
lib/optimizely/index.ts
Outdated
| this.logger?.error(INVALID_OBJECT, 'getAllFeatureVariables'); | ||
| return null; | ||
| } | ||
| const configObj = this.projectConfigManager.getConfig(); |
lib/optimizely/index.ts
Outdated
| const decisionMap: { [key: string]: OptimizelyDecision } = {}; | ||
| if (!this.isValidInstance() || !configObj) { | ||
| this.logger?.error(INVALID_OBJECT, 'decideAll'); | ||
| const configObj = this.projectConfigManager.getConfig(); |
raju-opti
force-pushed
the
raju/no_config
branch
from
b5487ee to
534177b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues