[FSSDK-12097] refactor OptimizelyUserContext tests using TS and vitest #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
raju-opti
December 3, 2025 16:40
There was a problem hiding this comment.
Pull request overview
This PR refactors the OptimizelyUserContext test suite from JavaScript (using Chai/Sinon) to TypeScript with vitest. The refactoring modernizes the test infrastructure while maintaining comprehensive test coverage for user context functionality including attribute management, decision-making, forced decisions, and segment qualification.
Key Changes
- Migrated from Chai assertions to vitest's
expectAPI - Replaced Sinon mocks with vitest's
vi.fn()mocking utilities - Updated mock helpers to use TypeScript types and standardized mock functions (
getMockLogger,getMockEventDispatcher) - Removed deprecated parameters (
shouldIdentifyUser,isValidInstance,eventBatchSize) that are no longer part of the API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| expect(user.qualifiedSegments).toEqual(['a']); | ||
| }); | ||
|
|
||
| it('should return true for empty returned segements', async () => { |
There was a problem hiding this comment.
Spelling error: "segements" should be "segments".
Suggested change
| it('should return true for empty returned segements', async () => { | |
| it('should return true for empty returned segments', async () => { |
| * limitations under the License. | ||
| */ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| import { describe, it, beforeEach, afterEach, expect, vi, Mocked } from 'vitest'; |
There was a problem hiding this comment.
Unused import afterEach.
Suggested change
| import { describe, it, beforeEach, afterEach, expect, vi, Mocked } from 'vitest'; | |
| import { describe, it, beforeEach, expect, vi, Mocked } from 'vitest'; |
| import OptimizelyUserContext from './'; | ||
| import Optimizely from '../optimizely'; | ||
| import testData from '../tests/test_data'; | ||
| import { EventDispatcher, NotificationCenter, OptimizelyDecideOption } from '../shared_types'; |
There was a problem hiding this comment.
Unused imports EventDispatcher, NotificationCenter.
Suggested change
| import { EventDispatcher, NotificationCenter, OptimizelyDecideOption } from '../shared_types'; | |
| import { OptimizelyDecideOption } from '../shared_types'; |
| import { getMockProjectConfigManager } from '../tests/mock/mock_project_config_manager'; | ||
| import { createProjectConfig } from '../project_config/project_config'; | ||
| import { getForwardingEventProcessor } from '../event_processor/event_processor_factory'; | ||
| import { FORCED_DECISION_NULL_RULE_KEY } from './index'; |
There was a problem hiding this comment.
Unused import FORCED_DECISION_NULL_RULE_KEY.
Suggested change
| import { FORCED_DECISION_NULL_RULE_KEY } from './index'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues