Skip to content

Conversation

@raju-opti
Copy link
Contributor

Summary

Test plan

  • added new tests

Issues

  • FSSDK-11125

@raju-opti raju-opti requested a review from jaeopt February 26, 2025 23:46
@raju-opti raju-opti assigned jaeopt and unassigned raju-opti Feb 26, 2025
@coveralls
Copy link

coveralls commented Feb 26, 2025

Coverage Status

coverage: 82.055% (+0.003%) from 82.052%
when pulling f4e3a1f on raju/cmab_client
into 6861f65 on master.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some suggestions about terms. Let me know if not happy with the new terms :)

@raju-opti raju-opti requested a review from jaeopt March 5, 2025 18:23
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit a4c27a2 into master Mar 5, 2025
10 of 15 checks passed
@raju-opti raju-opti deleted the raju/cmab_client branch March 5, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants