Skip to content

[FSSDK-11114] add type test for entrypoints #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raju-opti merged 1 commit into from
Feb 18, 2025
Merged

[FSSDK-11114] add type test for entrypoints #1004

raju-opti merged 1 commit into from
Feb 18, 2025

Conversation

@raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Feb 17, 2025

Summary

  • add vitest type tests for the entrypoints to ensure that all three entrypoints export the same api

Test plan

  • added type test for entrypoints

Issues

  • FSSDK-11114

@coveralls
Copy link

coveralls commented Feb 17, 2025

Coverage Status

coverage: 82.062% (-0.009%) from 82.071%
when pulling d5100c1 on raju/entrypoint_types
into 1f82bdb on master.

junaed-optimizely
junaed-optimizely approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit 49c6b8a into master Feb 18, 2025
11 of 20 checks passed
@raju-opti raju-opti deleted the raju/entrypoint_types branch February 18, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raju-opti @coveralls @junaed-optimizely