[FSSDK-11100] JS - rewrite audience_avaluator tests in TypeScript #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra/FSSDK-11100_audience_evaluator_test
junaed-optimizely
approved these changes
Feb 13, 2025
Contributor
junaed-optimizely
left a comment
junaed-optimizely
left a comment
There was a problem hiding this comment.
LGTM! Just one NIT
|
|
||
| expect(result).toBe(false); | ||
|
|
||
| vi.restoreAllMocks(); |
Contributor
There was a problem hiding this comment.
You can remove this redundant restore call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-wrote the following test in typescript:
The old tests are written using (mocha + chai + sinon). Used
vitestfeatures in the new tests.Test plan
Issues