fix(oncall): harden DST-safe schedule resolution - #378
Merged
Conversation
Dushyant-rahangdale
force-pushed
the
fix/oncall-dst-production-hardening
branch
from
August 25, 2026 20:29
536b48a to
7fcaf8f
Compare
Contributor
✅ Passed Vitest Results
|
Contributor
🔒 Security: Results Summary 4 files ±0 4 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit fd5cf77. ± Comparison against base commit 35de953. ♻️ This comment has been updated with latest results. |
Dushyant-rahangdale
force-pushed
the
fix/oncall-dst-production-hardening
branch
2 times, most recently
from
August 25, 2026 20:35
e244fc5 to
b4d7b3b
Compare
Dushyant-rahangdale
force-pushed
the
fix/oncall-dst-production-hardening
branch
from
August 26, 2026 05:40
b4d7b3b to
fd5cf77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production-hardens OpsKnight on-call scheduling around DST and timezone boundary behavior without a schema migration.
layer.startinstant, including starts intentionally placed in the second occurrence of a fall-back overlap.Pacific/Apiaskipping an entire civil day) cannot rewind the timeline or emit duplicate/overlapping duty blocks.1/2/3/4/6/8/12h).5h/7has exact elapsed-duration rotations so they remain contiguous through DST.Australia/Lord_Howe) rather than assuming every DST change is 60 minutes.Intl.DateTimeFormatconstruction.Safety / compatibility
Validation
Targeted timezone/on-call TypeScript validation and runtime matrices were exercised for:
America/New_Yorkspring-forward and fall-backAustralia/Lord_Howe30-minute DST transitionsPacific/Apiafull-day political timezone jump, including far-window fast-forwarding and duplicate-interval detectionLocal benchmark for the reported 90-day hourly case dropped from the reported ~1.68s/layer to roughly 75-100ms/layer in the validation runtime after formatter caching and resolver/expansion reductions.
The branch is intentionally kept to one atomic commit for easy review and rollback.