PICO type check update #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete the error message file.
… cannot be found. (#1)
Fix typos and unify the name of test filess.
Make testinput/typecheck/OnlyOneModifierIsUse.java pass
…CompatibilityBEI2.java pass. (opprop#8) Make CompatibilityBEI2.java pass.
# Conflicts: # src/main/java/pico/inference/PICOInferenceAnnotatedTypeFactory.java # src/main/java/pico/inference/PICOInferenceRealTypeFactory.java # src/main/java/pico/typecheck/PICOAnnotatedTypeFactory.java # src/main/java/pico/typecheck/PICOTypeUtil.java # src/main/java/qual/Bottom.java # src/main/java/qual/Immutable.java
Replace the error key "super.constructor.invocation.incompatible" with "super.invocation.invalid". Tweaks test files to pass the test.
Author
|
I have not fixed the inference part. Just comment out some outdate methods and update outdate APIs in the files. |
This was referenced May 8, 2024
Author
|
After this PR, we will turn on the CFI CI downstream task for PICO |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with opprop/checker-framework-inference#444.