Get arithmetic operation kind for compound assignments #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
reviewed
Feb 23, 2022
| */ | ||
| ArithmeticVariableSlot createArithmeticVariableSlot( | ||
| AnnotationLocation location, AnnotatedTypeMirror lhsAtm, AnnotatedTypeMirror rhsAtm); | ||
| AnnotationLocation location, TypeMirror lhs, TypeMirror rhs); |
There was a problem hiding this comment.
The names/comments in the javadoc above also need to be updated.
| @Override | ||
| public ArithmeticVariableSlot createArithmeticVariableSlot( | ||
| AnnotationLocation location, AnnotatedTypeMirror lhsAtm, AnnotatedTypeMirror rhsAtm) { | ||
| AnnotationLocation location, TypeMirror lhs, TypeMirror rhs) { |
There was a problem hiding this comment.
Why are there no calls to this method that need to be changed?
There was a problem hiding this comment.
Because ArithmeticVariableSlots are only created in the value-inference downstream
| * Determine the type kind of an arithmetic operation, based on Binary Numeric Promotion in JLS 5.6.2. | ||
| * @param lhsAtm atm of left operand | ||
| * @param rhsAtm atm of right operand | ||
| * @param lhsType type of left operand |
There was a problem hiding this comment.
Could you break this PR into two, one for compound assignments and one for these parameter type changes?
Co-authored-by: Werner Dietl <[email protected]>
…inference into value-patch-1
|
@d367wang Thanks! Is there a follow-up PR for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A split of #331
SlotManager.createArithmeticVariableSlotCo-authored-by: Jenny Xiang [email protected]