Report AlwaysFalseConstraints as CF errors
#341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
reviewed
Jul 13, 2021
Co-authored-by: Werner Dietl <[email protected]>
…inference into unsat-verify
…inference into unsat-verify
d367wang
changed the title
AlwaysFalseConstraints as a CF error
d367wang
changed the title
AlwaysFalseConstraints as a CF errorAlwaysFalseConstraints as CF errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CFI sets the CF flag
-Awarnsto turn the hard error to warning, so that the inference won't terminate when encountering any, aschecker-framework-inference/src/checkers/inference/InferenceMain.java
Line 168 in 21dfba4
But it's still necessary to report the error. In this way, we both point out the existing hard errors, and infer a solution (or prove UNSAT) for the user.