docs: adds note about defaultTags #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/zipkin/src/tracer/index.js
Outdated
| @@ -39,6 +39,8 @@ class Tracer { | |||
| localEndpoint, | |||
| /* eslint-disable no-console */ | |||
| log = console, | |||
| // defaultTags allows the user to pass tahs that should be added to all spans by | |||
There was a problem hiding this comment.
I'd tighten it up though curious how this question came up.. where did they think the tags would go? maybe it can help revise the comment.
"defaultTags custom tags to add to all sampled spans. defaults to empty"
There was a problem hiding this comment.
I like documenting my issues so I was grabbing references to open hypertrace/agent-config#21 then I realized some params have comments and some don't and hence I felt the need to improve this.
jcchavezs
commented
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @adriancole @ghermeto