Adds Brave Encoding support for v2 #208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new artifacts to allow StackdriverSender to have no zipkin dependency:
The main change is
StackdriverEncoder.V2
is moved to a new package:zipkin2.reporter.stackdriver.zipkin
, where it was formerly one level up. This is the part that decouples the classpath.Most won't use this encoder anymore as you can use Brave directly like so: