-
-
Couldn't load subscription status.
- Fork 16
omit blank settings in requests view #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 56.95% 57.36% +0.40%
==========================================
Files 12 13 +1
Lines 546 584 +38
Branches 79 82 +3
==========================================
+ Hits 311 335 +24
- Misses 233 246 +13
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
897c15f to
604052a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously needs to be revisited after my input in #176
Additional Changes
Couldn't really apply the changes from #176 , so, I decided to add everything here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you tried dev stack from end-to-end?
Looks like it is not working properly on my end, I suspect we should probably update dev/docker-compose.yml to pass proper "up-to-date" values to both ZIMIT_IMAGE (openzim/zimit:3.0.5) and ZIMIT_DEFINITION_VERSION (initial) so that dev stack works correctly.
Or do I miss something?
I'm not sure either the stack is really up-to-date with latest Zimfarm updates. Probably we should rather move to a strategy like WP1 where we make zimfarm dev compose graph live next to zimit-frontend dev compose graph, and remove any zimfarm-related components from zimit-frontend dev compose graph.
Yes, but not with the compose. Did it manually. Will update the compose file... |
|
Updated the docker compose graph and README to fully communicate with zimfarm. Zimfarm workers will need to be started with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
I also ran into an issue while testing because my ghcr.io/openzim/zimfarm-ui:latest image was totally outdated. I don't know how we are supposed to pull these base images with docker compose. We should either find proper docker compose command or mention somewhere in the doc that user should docker pull these images on a regular basis.
|
updated docker compose commands to use |
Changes
This closes #164