Skip to content

Conversation

@elfkuzco
Copy link
Collaborator

Changes

  • fetch the offliner definition for the current task
  • extract the label of the field in its offliner definition
  • omit blank settings from the view
Screenshot_20251015_122131

This closes #164

@elfkuzco elfkuzco self-assigned this Oct 15, 2025
@elfkuzco elfkuzco requested a review from benoit74 October 15, 2025 11:28
@elfkuzco elfkuzco linked an issue Oct 15, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 61.53846% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.36%. Comparing base (c5a8882) to head (3d2c307).

Files with missing lines Patch % Lines
api/src/zimitfrontend/routes/offliners.py 0.00% 12 Missing ⚠️
api/src/zimitfrontend/main.py 0.00% 2 Missing ⚠️
api/src/zimitfrontend/constants.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   56.95%   57.36%   +0.40%     
==========================================
  Files          12       13       +1     
  Lines         546      584      +38     
  Branches       79       82       +3     
==========================================
+ Hits          311      335      +24     
- Misses        233      246      +13     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously needs to be revisited after my input in #176

@elfkuzco elfkuzco changed the base branch from use-offliner-definition-version to main October 16, 2025 11:33
@elfkuzco
Copy link
Collaborator Author

Additional Changes

  • remove zimfarm api from config
  • use zimit_definition_version environment variable or split from image tag
  • add route to get the definition version
  • update ui

Couldn't really apply the changes from #176 , so, I decided to add everything here.

@elfkuzco elfkuzco requested a review from benoit74 October 16, 2025 12:14
@elfkuzco elfkuzco linked an issue Oct 16, 2025 that may be closed by this pull request
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you tried dev stack from end-to-end?

Looks like it is not working properly on my end, I suspect we should probably update dev/docker-compose.yml to pass proper "up-to-date" values to both ZIMIT_IMAGE (openzim/zimit:3.0.5) and ZIMIT_DEFINITION_VERSION (initial) so that dev stack works correctly.

Or do I miss something?

I'm not sure either the stack is really up-to-date with latest Zimfarm updates. Probably we should rather move to a strategy like WP1 where we make zimfarm dev compose graph live next to zimit-frontend dev compose graph, and remove any zimfarm-related components from zimit-frontend dev compose graph.

@elfkuzco
Copy link
Collaborator Author

Did you tried dev stack from end-to-end?

Yes, but not with the compose. Did it manually. Will update the compose file...

@elfkuzco
Copy link
Collaborator Author

Updated the docker compose graph and README to fully communicate with zimfarm. Zimfarm workers will need to be started with the worker profile. See Docker profiles

@elfkuzco elfkuzco requested a review from benoit74 October 20, 2025 11:50
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

I also ran into an issue while testing because my ghcr.io/openzim/zimfarm-ui:latest image was totally outdated. I don't know how we are supposed to pull these base images with docker compose. We should either find proper docker compose command or mention somewhere in the doc that user should docker pull these images on a regular basis.

@elfkuzco
Copy link
Collaborator Author

updated docker compose commands to use --pull always. This ensures we always get the latest image.

@elfkuzco elfkuzco requested a review from benoit74 October 23, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly use offliner definition version Many blank settings are displayed

3 participants