-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZTS: add centos stream10 #16904
base: master
Are you sure you want to change the base?
ZTS: add centos stream10 #16904
Conversation
Some tests failed:
|
I like more targets to test on, but I'm reluctant to automatically test on CentOS Stream by default. Stream is not supported by OpenZFS since it's such a moving target. I would hate to have people's PRs suddenly have test failures simply because Stream changed something under the rug. That said, would you consider making this an optional, Example: (code below is untested) diff --git a/.github/workflows/zfs-qemu.yml b/.github/workflows/zfs-qemu.yml
index 4748e90db..1d72650de 100644
--- a/.github/workflows/zfs-qemu.yml
+++ b/.github/workflows/zfs-qemu.yml
@@ -3,6 +3,18 @@ name: zfs-qemu
on:
push:
pull_request:
+ workflow_dispatch:
+ inputs:
+ include_stream9:
+ type: boolean
+ required: false
+ default: false
+ description: 'Test on CentOS 9 stream'
+ include_stream10:
+ type: boolean
+ required: false
+ default: false
+ description: 'Test on CentOS 10 stream'
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
@@ -37,6 +49,15 @@ jobs:
os_selection="$FULL_OS"
fi
os_json=$(echo ${os_selection} | jq -c)
+
+ # Add on optional runners
+ if [ ${{ github.event.inputs.include_stream9 }} == "true" ] ; then
+ os_json="$(echo $os_json | jq -c '. += ["centos-stream9"]')"
+ fi
+ if [ ${{ github.event.inputs.include_stream10 }} == "true" ] ; then
+ os_json="$(echo $os_json | jq -c '. += ["centos-stream10"]')"
+ fi
+
echo "os=$os_json" >> $GITHUB_OUTPUT
echo "ci_type=$ci_type" >> $GITHUB_OUTPUT NOTE! If you want these nice |
So should I remove See results of https://github.com/hanthor/zfs/actions/runs/12512921350/job/34906851668 for |
Added centos as optional runners via workflow_dispatch removed centos-stream9 from the FULL_OS runner list as CentOS is not officially support by ZFS. This commit will add preliminary support for EL10 and allow testing ZFS ahead of EL10 codebase solidifying in ~6 months Signed-off-by: James Reilly <[email protected]>
Motivation and Context
CentOS-stream10 is out. It would be nice to have ZFS support
We will be adding stream9 and stream10 as optional runners for testing incoming EL changes. As CentOS Stream does not have official ZFS support
Description
I copied the work to add fedora 41 from here: #16700
How Has This Been Tested?
It has been built in CI on my fork, will be testing in CI with this draft PR
Types of changes
Checklist:
Signed-off-by
](https://github.com/openzfs/zfs/blob/master/.github/CONTRIBUTING.md#signed-offsupport