-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hub leader config controller #2299
feat: add hub leader config controller #2299
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2299 +/- ##
=========================================
Coverage ? 45.30%
=========================================
Files ? 410
Lines ? 27152
Branches ? 0
=========================================
Hits ? 12301
Misses ? 13627
Partials ? 1224
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # pkg/yurtmanager/controller/base/controller.go
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Show resolved
Hide resolved
cba4e4b
to
f5b0b86
Compare
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Show resolved
Hide resolved
|
/LGTM |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds hubleader config controller to create configmap for the nodepool leader and pool scoped metadata
Which issue(s) this PR fixes:
Fixes #2260
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note
An internal CRD would be an improvement than a configmap to have a structured schema. Endpoints resource was not used due to character limitations using annotations to store poolscoped metadata. It was decided to use a config map instead.