Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve direct clientsets for yurthub #2285

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

Use Clientset directly instead of using rest config in order to improve the performance of yurthub. because yurthub.conf file should be loaded when rest config is used each time.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@rambohe-ch rambohe-ch requested a review from a team as a code owner February 1, 2025 00:06
@rambohe-ch
Copy link
Member Author

@zyjhtangtang @vie-serendipity PTAL

@rambohe-ch rambohe-ch force-pushed the improve-direct-clients branch 2 times, most recently from 90ba12e to 391e821 Compare February 2, 2025 01:52
@rambohe-ch rambohe-ch force-pushed the improve-direct-clients branch from 391e821 to 7b661fe Compare February 2, 2025 13:55
Copy link

sonarqubecloud bot commented Feb 2, 2025

@rambohe-ch
Copy link
Member Author

@zyjhtangtang @vie-serendipity PTAL

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 54.28571% with 32 lines in your changes missing coverage. Please review.

Project coverage is 46.40%. Comparing base (175c309) to head (7b661fe).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/yurthub/gc/gc.go 0.00% 8 Missing ⚠️
pkg/yurthub/proxy/autonomy/autonomy.go 42.85% 8 Missing ⚠️
cmd/yurthub/app/start.go 0.00% 5 Missing ⚠️
pkg/yurthub/kubernetes/directclient/manager.go 85.71% 2 Missing and 2 partials ⚠️
pkg/yurthub/server/server.go 0.00% 4 Missing ⚠️
pkg/yurthub/server/nonresource.go 60.00% 2 Missing ⚠️
pkg/yurthub/proxy/proxy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2285      +/-   ##
==========================================
+ Coverage   46.20%   46.40%   +0.20%     
==========================================
  Files         416      416              
  Lines       27279    27266      -13     
==========================================
+ Hits        12604    12653      +49     
+ Misses      13404    13333      -71     
- Partials     1271     1280       +9     
Flag Coverage Δ
unittests 46.40% <54.28%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zyjhtangtang
Copy link
Contributor

/LGTM

@zyjhtangtang zyjhtangtang merged commit d690808 into openyurtio:master Feb 2, 2025
14 checks passed
@rambohe-ch
Copy link
Member Author

/backport release-v1.6

Copy link

github-actions bot commented Feb 3, 2025

Successfully created backport PR for release-v1.6:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants